tabs

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245// The convergence/tabs service methods and the legacy shared requests.
// Real activation against a fake service bus: calls go through the provided
// implementation, events through its handle, legacy requests through app state.
import assert from "node:assert/strict";
import { test } from "node:test";
import type {
  Api,
  AppState,
  AppStatePatch,
  HostEvent,
  RenderResult,
  SlotOptions,
  ViewContext,
} from "convergence";
import { ui } from "convergence";
import { testLayer } from "convergence/effect/testing";
import { activate } from "./main.ts";

const tick = () => new Promise<void>((resolve) => setImmediate(resolve));
const stable = (value: unknown) =>
  JSON.stringify(value, (_key, item: unknown) => (typeof item === "function" ? "@handler" : item));

type ServiceImpl = Record<string, (params: never, ctx: unknown) => Promise<unknown>>;
type Emitted = { event: string; payload: unknown };

function fakeApi() {
  let state: AppState = {};
  const appListeners = new Set<(state: AppState) => void>();
  const views: { render: (ctx: ViewContext<object>) => RenderResult; active: boolean }[] = [];
  const listeners = new Map<string, Set<(event: HostEvent) => unknown>>();
  const calls: { method: string; params: unknown }[] = [];
  const notices: string[] = [];
  let dirty = true;
  const provided = new Map<string, ServiceImpl>();
  const emitted: Emitted[] = [];
  const update = (patch: AppStatePatch) => {
    state = {
      ...state,
      ...patch,
      workspaceId: patch.workspaceId === null ? undefined : (patch.workspaceId ?? state.workspaceId),
      chatId: patch.chatId === null ? undefined : (patch.chatId ?? state.chatId),
      route: patch.route ?? state.route,
      shared: { ...state.shared, ...patch.shared },
    };
    dirty = true;
    for (const listener of appListeners) listener(state);
  };
  const call = async (method: string, params: unknown) => {
    calls.push({ method, params });
    if (method === "host/fs.read") return { text: `# ${(params as { path: string }).path}\nbody` };
    throw new Error(`Unexpected host method ${method}`);
  };
  const broker = testLayer();
  // This assertion describes a local fake; unused API methods fail rather than impersonating external replies.
  const api = new Proxy(
    {
      ...broker.api,
      plugin: "tabs",
      id: "convergence/tabs",
      ui,
      services: {
        provide: async (def: { name: string }, impl: ServiceImpl) => {
          provided.set(def.name, impl);
          return {
            emit: (event: string, payload: unknown) => {
              emitted.push({ event, payload });
            },
            remove: () => {
              provided.delete(def.name);
            },
          };
        },
        get: (name: string) => {
          throw new Error(`no provider for ${name}`);
        },
        available: () => false,
        when: () => () => {},
      },
      host: { ...broker.api.host, call, kernel: call },
      app: {
        state: () => state,
        update,
        share: (key: string, value: unknown) => update({ shared: { [key]: value } }),
        onChange: (fn: (state: AppState) => void) => {
          appListeners.add(fn);
          return () => {
            appListeners.delete(fn);
          };
        },
      },
      slot: (slot: string, render: (ctx: ViewContext<object>) => RenderResult, _options?: SlotOptions) => {
        const view = { render, active: true };
        views.push(view);
        dirty = true;
        return {
          id: views.length,
          update: () => {
            dirty = true;
          },
          remove: () => {
            view.active = false;
          },
        };
      },
      on: (name: string, fn: (event: HostEvent) => unknown) => {
        const subscribers = listeners.get(name) ?? new Set();
        listeners.set(name, subscribers);
        subscribers.add(fn);
        return () => {
          subscribers.delete(fn);
        };
      },
      command: () => ({ remove() {} }),
      notify: (message: string) => {
        notices.push(message);
      },
      focus: () => {},
    },
    {
      get(target, key, receiver) {
        if (Reflect.has(target, key)) return Reflect.get(target, key, receiver);
        throw new Error(`Unexpected API ${String(key)}`);
      },
    },
  ) as unknown as Api;
  const render = () =>
    views
      .filter((view) => view.active)
      .map((view) =>
        view.render({
          state: {},
          app: state,
          plugin: "tabs",
          update: () => {
            dirty = true;
          },
        }),
      );
  let trees: RenderResult[] = [];
  const settle = async () => {
    for (let round = 0; round < 50; round++) {
      await tick();
      if (!dirty) {
        await tick();
        if (!dirty) return;
      }
      dirty = false;
      trees = render();
    }
    throw new Error("tabs did not settle");
  };
  const ctx = { caller: { plugin: "test/client", id: "test/client" }, signal: AbortSignal.timeout(5000) };
  return {
    api,
    calls,
    notices,
    callsReset: () => {
      calls.length = 0;
    },
    emitted,
    provided,
    update,
    settle,
    trees: () => stable(trees),
    state: () => state,
    callService: (method: string, params: unknown) =>
      provided.get("convergence/tabs")?.[method]?.(params as never, ctx),
    emit: (event: HostEvent) => {
      for (const name of [event.event, "*"]) for (const fn of listeners.get(name) ?? []) fn(event);
    },
  };
}

test("the tabs service opens, reports and closes tabs without shared writes", async () => {
  const fake = fakeApi();
  const dispose = activate(fake.api);
  try {
    await fake.settle();
    assert.ok(fake.provided.has("convergence/tabs"));
    assert.deepEqual(await fake.callService("active", {}), null);
    assert.deepEqual(await fake.callService("open", { kind: "file", workspaceId: "w1", path: "a.ts" }), {
      id: "file:w1:a.ts",
    });
    await fake.settle();
    assert.deepEqual(fake.emitted, [{ event: "activeChanged", payload: { kind: "file", path: "a.ts" } }]);
    // The visible tab left the shared keys behind: nothing announces through them.
    assert.equal(fake.state().shared?.activeTab, undefined);
    assert.equal(fake.state().shared?.activeTabPath, undefined);
    assert.deepEqual(await fake.callService("active", {}), { kind: "file", path: "a.ts" });
    assert.ok(fake.trees().includes("file:w1:a.ts"));
    fake.callsReset();
    assert.deepEqual(await fake.callService("close", { kind: "file", path: "a.ts" }), null);
    await fake.settle();
    assert.deepEqual(fake.emitted.at(-1), { event: "activeChanged", payload: null });
    assert.deepEqual(await fake.callService("active", {}), null);
    assert.ok(!fake.trees().includes("file:w1:a.ts"));
  } finally {
    await dispose();
  }
});

test("the tabs service opens view tabs and ignores unknown closes", async () => {
  const fake = fakeApi();
  const dispose = activate(fake.api);
  try {
    await fake.settle();
    assert.deepEqual(
      await fake.callService("open", {
        kind: "view",
        workspaceId: "w1",
        path: "agents",
        title: "Agents",
        icon: "network",
        view: 3,
      }),
      { id: "view:w1:agents" },
    );
    await fake.settle();
    assert.ok(fake.trees().includes("Agents"));
    const seen = fake.emitted.length;
    assert.deepEqual(await fake.callService("close", { kind: "diff", path: "missing.ts" }), null);
    assert.equal(fake.emitted.length, seen);
  } finally {
    await dispose();
  }
});

test("legacy shared open and close requests still work", async () => {
  const fake = fakeApi();
  const dispose = activate(fake.api);
  try {
    await fake.settle();
    fake.update({ shared: { openTab: { kind: "diff", workspaceId: "w1", path: "b.ts", diff: "@@\n", nonce: 1 } } });
    await fake.settle();
    assert.equal(fake.state().shared?.openTab, null);
    assert.deepEqual(fake.emitted, [{ event: "activeChanged", payload: { kind: "diff", path: "b.ts" } }]);
    assert.ok(fake.trees().includes("diff:w1:b.ts"));
    fake.update({ shared: { closeTab: { kind: "diff", path: "b.ts", nonce: 2 } } });
    await fake.settle();
    assert.equal(fake.state().shared?.closeTab, null);
    assert.deepEqual(fake.emitted.at(-1), { event: "activeChanged", payload: null });
  } finally {
    await dispose();
  }
});